From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available Date: Tue, 19 Dec 2017 13:20:17 -0500 (EST) Message-ID: <20171219.132017.1652469595167726292.davem@davemloft.net> References: <1513644036-45230-1-git-send-email-sridhar.samudrala@intel.com> <20171219174259-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Cc: mst@redhat.com, stephen@networkplumber.org, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, alexander.duyck@gmail.com, jesse.brandeburg@intel.com To: sridhar.samudrala@intel.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:54488 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbdLSSUV (ORCPT ); Tue, 19 Dec 2017 13:20:21 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: "Samudrala, Sridhar" Date: Tue, 19 Dec 2017 09:41:39 -0800 > This is based on netvsc implementation and here is the commit that > added this delay.  Not sure if this needs to be 100ms. > > commit 6123c66854c174e4982f98195100c1d990f9e5e6 > Author: stephen hemminger > Date:   Wed Aug 9 17:46:03 2017 -0700 > >     netvsc: delay setup of VF device > >     When VF device is discovered, delay bring it automatically up in >     order to allow userspace to some simple changes (like renaming). This is kind of bogus, I should have called this out when the patch was posted. Any delay is wrong, there needs to be tight synchronization if a userspace operation must occur before proceeding. If something happens and userspace is delayed, this whole thing doesn't work.