netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: al.kochet@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	f.fainelli@gmail.com, edumazet@google.com
Subject: Re: [PATCH v2] net: arc_emac: restart stalled EMAC
Date: Tue, 19 Dec 2017 13:26:23 -0500 (EST)	[thread overview]
Message-ID: <20171219.132623.806348776830008384.davem@davemloft.net> (raw)
In-Reply-To: <1513681437-32248-1-git-send-email-al.kochet@gmail.com>

From: Alexander Kochetkov <al.kochet@gmail.com>
Date: Tue, 19 Dec 2017 14:03:57 +0300

> Under certain conditions EMAC stop reception of incoming packets and
> continuously increment R_MISS register instead of saving data into
> provided buffer. The commit implement workaround for such situation.
> Then the stall detected EMAC will be restarted.
> 
> On device the stall looks like the device lost it's dynamic IP address.
> ifconfig shows that interface error counter rapidly increments.
> At the same time on the DHCP server we can see continues DHCP-requests
> from device.
> 
> In real network stalls happen really rarely. To make them frequent the
> broadcast storm[1] should be simulated. For simulation it is necessary
> to make following connections:
>     1. connect radxarock to 1st port of switch
>     2. connect some PC to 2nd port of switch
>     3. connect two other free ports together using standard ethernet cable,
>        in order to make a switching loop.
> 
> After that, is necessary to make a broadcast storm. For example, running on
> PC 'ping' to some IP address triggers ARP-request storm. After some
> time (~10sec), EMAC on rk3188 will stall.
> 
> Observed and tested on rk3188 radxarock.
> 
> [1] https://en.wikipedia.org/wiki/Broadcast_radiation
> 
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>

Applied.

  reply	other threads:[~2017-12-19 18:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 17:20 [PATCH] net: arc_emac: fix arc_emac_rx() error paths Alexander Kochetkov
2017-12-19 11:03 ` [PATCH v2] net: arc_emac: restart stalled EMAC Alexander Kochetkov
2017-12-19 18:26   ` David Miller [this message]
2017-12-19 11:07 ` [PATCH v2] net: arc_emac: fix arc_emac_rx() error paths Alexander Kochetkov
2017-12-19 18:26   ` David Miller
2017-12-19 15:22 ` [PATCH] " David Miller
2017-12-19 15:49   ` Alexander Kochetkov
2017-12-19 16:41     ` David Miller
2017-12-19 18:33     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171219.132623.806348776830008384.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=al.kochet@gmail.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).