From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2] net: arc_emac: fix arc_emac_rx() error paths Date: Tue, 19 Dec 2017 13:26:30 -0500 (EST) Message-ID: <20171219.132630.1816700498837086028.davem@davemloft.net> References: <1513358406-32503-1-git-send-email-al.kochet@gmail.com> <1513681624-32375-1-git-send-email-al.kochet@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, f.fainelli@gmail.com, edumazet@google.com To: al.kochet@gmail.com Return-path: In-Reply-To: <1513681624-32375-1-git-send-email-al.kochet@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Alexander Kochetkov Date: Tue, 19 Dec 2017 14:07:04 +0300 > arc_emac_rx() has some issues found by code review. > > In case netdev_alloc_skb_ip_align() or dma_map_single() failure > rx fifo entry will not be returned to EMAC. > > In case dma_map_single() failure previously allocated skb became > lost to driver. At the same time address of newly allocated skb > will not be provided to EMAC. > > Signed-off-by: Alexander Kochetkov Applied.