From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ip6_tunnel: get the min mtu properly in ip6_tnl_xmit
Date: Tue, 19 Dec 2017 13:46:08 -0500 (EST) [thread overview]
Message-ID: <20171219.134608.2000549901090270883.davem@davemloft.net> (raw)
In-Reply-To: <5a4b92b4ea3263c25d3faa158ea867a6946808a4.1513578381.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 18 Dec 2017 14:26:21 +0800
> Now it's using IPV6_MIN_MTU as the min mtu in ip6_tnl_xmit, but
> IPV6_MIN_MTU actually only works when the inner packet is ipv6.
>
> With IPV6_MIN_MTU for ipv4 packets, the new pmtu for inner dst
> couldn't be set less than 1280. It would cause tx_err and the
> packet to be dropped when the outer dst pmtu is close to 1280.
>
> Jianlin found it by running ipv4 traffic with the topo:
>
> (client) gre6 <---> eth1 (route) eth2 <---> gre6 (server)
>
> After changing eth2 mtu to 1300, the performance became very
> low, or the connection was even broken. The issue also affects
> ip4ip6 and ip6ip6 tunnels.
>
> So if the inner packet is ipv4, 576 should be considered as the
> min mtu.
>
> Note that for ip4ip6 and ip6ip6 tunnels, the inner packet can
> only be ipv4 or ipv6, but for gre6 tunnel, it may also be ARP.
> This patch using 576 as the min mtu for non-ipv6 packet works
> for all those cases.
>
> Reported-by: Jianlin Shi <jishi@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied.
prev parent reply other threads:[~2017-12-19 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 6:26 [PATCH net] ip6_tunnel: get the min mtu properly in ip6_tnl_xmit Xin Long
2017-12-19 18:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219.134608.2000549901090270883.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox