From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: netdev@vger.kernel.org, jarod@redhat.com
Subject: Re: [PATCH net] ip_gre: remove the incorrect mtu limit for ipgre tap
Date: Tue, 19 Dec 2017 13:46:14 -0500 (EST) [thread overview]
Message-ID: <20171219.134614.2202609526764522327.davem@davemloft.net> (raw)
In-Reply-To: <39491900680cdfcf8b0e7e410ba8aa1ba52e1bd2.1513578275.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 18 Dec 2017 14:24:35 +0800
> ipgre tap driver calls ether_setup(), after commit 61e84623ace3
> ("net: centralize net_device min/max MTU checking"), the range
> of mtu is [min_mtu, max_mtu], which is [68, 1500] by default.
>
> It causes the dev mtu of the ipgre tap device to not be greater
> than 1500, this limit value is not correct for ipgre tap device.
>
> Besides, it's .change_mtu already does the right check. So this
> patch is just to set max_mtu as 0, and leave the check to it's
> .change_mtu.
>
> Fixes: 61e84623ace3 ("net: centralize net_device min/max MTU checking")
> Reported-by: Jianlin Shi <jishi@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied.
prev parent reply other threads:[~2017-12-19 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 6:24 [PATCH net] ip_gre: remove the incorrect mtu limit for ipgre tap Xin Long
2017-12-19 18:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219.134614.2202609526764522327.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jarod@redhat.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox