From: David Miller <davem@davemloft.net>
To: shli@kernel.org
Cc: netdev@vger.kernel.org, Kernel-team@fb.com, shli@fb.com, kafai@fb.com
Subject: Re: [PATCH net] net: always reevalulate autoflowlabel setting for reset packet
Date: Tue, 19 Dec 2017 14:15:33 -0500 (EST) [thread overview]
Message-ID: <20171219.141533.1790109391093303587.davem@davemloft.net> (raw)
In-Reply-To: <b20c7b756a507786dbbe2127b3c014954a1587fd.1513652093.git.shli@fb.com>
From: Shaohua Li <shli@kernel.org>
Date: Mon, 18 Dec 2017 18:58:25 -0800
> @@ -789,7 +789,9 @@ static void tcp_v6_send_response(const struct sock *sk, struct sk_buff *skb, u32
> unsigned int tot_len = sizeof(struct tcphdr);
> struct dst_entry *dst;
> __be32 *topt;
> + struct ipv6_pinfo *np = inet6_sk(ctl_sk);
>
> + np->autoflowlabel = ip6_default_np_autolabel(net);
Please put the 'np' variable declaration a few lines up in order to preserve
the reverse christmas tree ordering of local variables (longest to
shortest line).
THank you.
prev parent reply other threads:[~2017-12-19 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 2:58 [PATCH net] net: always reevalulate autoflowlabel setting for reset packet Shaohua Li
2017-12-19 19:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219.141533.1790109391093303587.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Kernel-team@fb.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=shli@fb.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox