From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tobin C. Harding" Subject: Re: [PATCH 1/3] kallsyms: don't leak address when symbol not found Date: Tue, 19 Dec 2017 11:24:18 +1100 Message-ID: <20171219002418.GF19604@eros> References: <1513554812-13014-1-git-send-email-me@tobin.cc> <1513554812-13014-2-git-send-email-me@tobin.cc> <5b86abe3-2c9d-1396-777d-a5a8f19555ef@nbd.name> <1513636889.2482269.1209330464.6971721E@webmail.messagingengine.com> <20171218184324.527ffd0e@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Felix Fietkau , kernel-hardening@lists.openwall.com, Tycho Andersen , Linus Torvalds , Kees Cook , Andrew Morton , Daniel Borkmann , Masahiro Yamada , Alexei Starovoitov , linux-kernel@vger.kernel.org, Network Development To: Steven Rostedt Return-path: Content-Disposition: inline In-Reply-To: <20171218184324.527ffd0e@gandalf.local.home> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, Dec 18, 2017 at 06:43:24PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 09:41:29 +1100 > "Tobin C. Harding" wrote: > > > Current suggestion on list is to remove this function. Do you have a use > > case in mind where debugging will break? We could add a fix to this > > series if so. Otherwise next version will likely drop > > string_is_no_symbol() > > What about adding a kernel command line parameter that lets one put > back the old behavior. > > "insecure_print_all_symbols" ? Cool. I've not done that before it will be a good learning experience. I'll hack it up and see what people think. thanks, Tobin.