From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 0/3] ip/tunnels: Reuse code, vti6 zero endpoint support and minor cleanup Date: Tue, 19 Dec 2017 08:19:11 -0800 Message-ID: <20171219081911.6d316d83@xeon-e3> References: <1513619285-23187-1-git-send-email-serhe.popovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Serhey Popovych Return-path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:36885 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbdLSQTP (ORCPT ); Tue, 19 Dec 2017 11:19:15 -0500 Received: by mail-pl0-f67.google.com with SMTP id s3so7237455plp.4 for ; Tue, 19 Dec 2017 08:19:15 -0800 (PST) In-Reply-To: <1513619285-23187-1-git-send-email-serhe.popovych@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 18 Dec 2017 19:48:02 +0200 Serhey Popovych wrote: > In this series I present next set of improvements: > > 1) Use tnl_parse_key() to avoid code duplication in tunnel > configuration via netlink code. > > 2) Trivial: use IN6ADDR_ANY_INIT instead of open coded > initialization of local/remote endpoint in ip6tnl code. > > 3) Trivial: drop additional checks for zero endpoint > in vti6 code. This completes and unifies support for > unconfiguring local/remote endpoint for tunnel. > > See individual patch description message for details. > > Thanks, > Serhii > > Serhey Popovych (3): > ip/tunnel: Use tnl_parse_key() to parse tunnel key > link_ip6tnl: Use IN6ADDR_ANY_INIT to initialize local/remote > endpoints > link_vti6: Always add local/remote endpoint attributes > > ip/link_gre.c | 45 +++++---------------------------------------- > ip/link_gre6.c | 45 +++++---------------------------------------- > ip/link_ip6tnl.c | 4 ++-- > ip/link_vti.c | 45 +++++---------------------------------------- > ip/link_vti6.c | 51 +++++++-------------------------------------------- > ip/tunnel.c | 5 +++-- > 6 files changed, 27 insertions(+), 168 deletions(-) > Applied, thanks