From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Zubkov <green@msu.ru>
Cc: zubkov318@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] iproute: "list/flush/save default" selected all of the routes
Date: Tue, 19 Dec 2017 08:27:53 -0800 [thread overview]
Message-ID: <20171219082753.4e271cf9@xeon-e3> (raw)
In-Reply-To: <1513508940-29430-1-git-send-email-green@msu.ru>
On Sun, 17 Dec 2017 12:09:00 +0100
Alexander Zubkov <green@msu.ru> wrote:
> When running "ip route list default" and not specifying address family,
> one will get all of the routes instead of just default only. The same
> is for "exact default" and "match default".
>
> It behaves in such a way because default route with unspecified family
> has the same all-zeroes value like no prefix specified at all. Thus
> following code blindly ignores the fact, that prefix was actually
> specified.
>
> This patch adds the flag PREFIXLEN_SPECIFIED to the default route too.
> And then checks its value when filtering routes.
>
> Signed-off-by: Alexander Zubkov <green@msu.ru>
Applied, thanks Alexander
next prev parent reply other threads:[~2017-12-19 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 13:12 [PATCH iproute2] ip route: broken logic when using default word and family not specified Alexander Zubkov
2017-11-18 16:56 ` Alexander Zubkov
2017-12-04 19:41 ` Alexander Zubkov
2017-12-06 1:42 ` Stephen Hemminger
2017-12-16 21:21 ` Stephen Hemminger
2017-12-17 11:09 ` [PATCH] iproute: "list/flush/save default" selected all of the routes Alexander Zubkov
2017-12-19 16:27 ` Stephen Hemminger [this message]
2017-12-17 12:06 ` [PATCH iproute2] ip route: broken logic when using default word and family not specified Alexander Zubkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219082753.4e271cf9@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=green@msu.ru \
--cc=netdev@vger.kernel.org \
--cc=zubkov318@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).