From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure Date: Tue, 19 Dec 2017 11:30:10 +0100 Message-ID: <20171219103010.GC1928@nanopsycho> References: <20171218111033.13256-1-ilyal@mellanox.com> <20171218171010.GB6823@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, davejwatson@fb.com, tom@herbertland.com, hannes@stressinduktion.org, borisp@mellanox.com, aviadye@mellanox.com, liranl@mellanox.com To: Ilya Lesokhin Return-path: Received: from mail-wm0-f44.google.com ([74.125.82.44]:40999 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933348AbdLSKaM (ORCPT ); Tue, 19 Dec 2017 05:30:12 -0500 Received: by mail-wm0-f44.google.com with SMTP id g75so2606677wme.0 for ; Tue, 19 Dec 2017 02:30:12 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171218171010.GB6823@nanopsycho> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Dec 18, 2017 at 06:10:10PM CET, jiri@resnulli.us wrote: >Mon, Dec 18, 2017 at 12:10:27PM CET, ilyal@mellanox.com wrote: >>Changes from v2: >>- Fix sk use after free and possible netdev use after free >>- tls device now keeps a refernce on the offloading netdev >>- tls device registers to the netdev notifer. >> Upon a NETDEV_DOWN event, offload is stopped and >> the reference on the netdev is dropped. >>- SW fallback support for skb->ip_summed != CHECKSUM_PARTIAL >>- Merged TLS patches are no longer part of this series. >> >>Changes from v1: >>- Remove the binding of the socket to a specific netdev >> through sk->sk_bound_dev_if. >> Add a check in validate_xmit_skb to detect route changes >> and call SW fallback code to do the crypto in software. >>- tls_get_record now returns the tls record sequence number. >> This is required to support connections with rcd_sn != iv. >>- Bug fixes to the TLS code. >> >>This patchset adds a generic infrastructure to offload TLS crypto to a >>network devices. >> >>patches 1-2 Export functions that we need >>patch 3 adds infrastructue for offloaded socket fallback >>patches 4-5 add new NDOs and capabilities. >>patch 6 adds the TLS NIC offload infrastructure. >> >>Github with mlx5e TLS offload support: >>https://github.com/Mellanox/tls-offload/tree/tls_device_v3 > >I don't get it. You are pushing infra but not the actual driver part >who is consuming the infra? Why? Okay. Since the driver that uses the API introduced by this patchset is missing, this patchset should be marked as RFC. Dave, I see that you were about to apply v2. I'm sure you missed this. Thanks.