From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available Date: Tue, 19 Dec 2017 11:46:27 -0800 Message-ID: <20171219114627.76dac732@xeon-e3> References: <20171219174259-mutt-send-email-mst@kernel.org> <20171219095548.61d70d10@xeon-e3> <20171219.132117.666798483874609477.davem@davemloft.net> <20171219104159.30d9caaf@xeon-e3> <344f0afc-b4aa-9f1a-15b8-166ba97d270b@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: David Miller , mst@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, alexander.duyck@gmail.com, jesse.brandeburg@intel.com To: "Samudrala, Sridhar" Return-path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:35206 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbdLSTqa (ORCPT ); Tue, 19 Dec 2017 14:46:30 -0500 Received: by mail-pg0-f68.google.com with SMTP id q20so10969660pgv.2 for ; Tue, 19 Dec 2017 11:46:30 -0800 (PST) In-Reply-To: <344f0afc-b4aa-9f1a-15b8-166ba97d270b@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 19 Dec 2017 11:42:33 -0800 "Samudrala, Sridhar" wrote: > On 12/19/2017 10:41 AM, Stephen Hemminger wrote: > > On Tue, 19 Dec 2017 13:21:17 -0500 (EST) > > David Miller wrote: > > > >> From: Stephen Hemminger > >> Date: Tue, 19 Dec 2017 09:55:48 -0800 > >> > >>> could be 10ms, just enough to let udev do its renaming > >> Please, move to some kind of notification or event based handling of > >> this problem. > >> > >> No delay is safe, what if userspace gets swapped out or whatever > >> else might make userspace stall unexpectedly? > >> > > The plan is to remove the delay and do the naming in the kernel. > > This was suggested by Lennart since udev is only doing naming policy > > because kernel names were not repeatable. > > > > This makes the VF show up as "ethN_vf" on Hyper-V which is user friendly. > > > > Patch is pending. > Do we really need to delay the setup until the name is changed? > Can't we call dev_set_mtu() and dev_open() until dev_change_name() is done? > > Thanks > Sridhar You can call dev_set_mtu, but when dev_open is done the device name can not be changed by userspace.