From: Jakub Kicinski <kubakici@wp.pl>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org,
Stephen Hemminger <sthemmin@microsoft.com>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [RFC] hv_netvsc: automatically name slave VF network device
Date: Tue, 19 Dec 2017 14:24:52 -0800 [thread overview]
Message-ID: <20171219142452.0f708189@cakuba.netronome.com> (raw)
In-Reply-To: <20171219140659.39f6cc1c@xeon-e3>
On Tue, 19 Dec 2017 14:06:59 -0800, Stephen Hemminger wrote:
> > > > > I assume you mean the modern application is udev, and it works
> > > > > but the name is meaningless because it based of synthetic PCI
> > > > > information. The PCI host adapter is simulated for pass through
> > > > > devices. Names like enp12s0.
> > > > >
> > > > > Since every passthrough VF device on Hyper-V/Azure has a matching
> > > > > synthetic network device with same mac address. It is best to
> > > > > have the relationship shown in the name.
> > > >
> > > > How about we make the VF drivers expose "vf" as phys_port_name?
> > > > Then systemd/udev should glue that onto the name regardless of
> > > > how the VF is used.
> > >
> > > One of the goals was not to modify in any way other drivers (like VF).
> >
> > Why? Do you have out-of-tree drivers you can't change or some such?
>
> This needs to work on enterprise distributions; plus it is not good
> practice to introduce random changes into partners like Mellanox
> drivers.
Are we talking about Linux or Windows kernel here? I don't think
this requires hypervisor changes? The notion of a "partner" and
changing drivers by people who are not employed by a vendor being
bad practice sounds entirely foreign to me.
If we agree that marking VF interfaces is useful (and I think
it is) then we should mark them always, not only when they are
enslaved to a magic bond. And the natural way of doing that
seems to be phys_port_name.
next prev parent reply other threads:[~2017-12-19 22:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 19:35 [RFC] hv_netvsc: automatically name slave VF network device Stephen Hemminger
2017-12-19 20:32 ` Jakub Kicinski
2017-12-19 20:44 ` Stephen Hemminger
2017-12-19 21:18 ` Jakub Kicinski
2017-12-19 21:29 ` Stephen Hemminger
2017-12-19 21:55 ` Jakub Kicinski
2017-12-19 22:06 ` Stephen Hemminger
2017-12-19 22:24 ` Jakub Kicinski [this message]
2017-12-19 22:51 ` Stephen Hemminger
2017-12-19 22:44 ` Samudrala, Sridhar
2017-12-19 22:50 ` Stephen Hemminger
2017-12-19 23:20 ` Jakub Kicinski
2017-12-19 23:44 ` Stephen Hemminger
2017-12-19 23:53 ` Jakub Kicinski
2017-12-20 6:41 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219142452.0f708189@cakuba.netronome.com \
--to=kubakici@wp.pl \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).