From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next] mlxsw: spectrum: Add "spectrum" prefix macro Date: Tue, 19 Dec 2017 17:17:36 +0100 Message-ID: <20171219161736.GH1928@nanopsycho> References: <20171217161534.2446-1-jiri@resnulli.us> <1513527900.31581.27.camel@perches.com> <20171219.110906.560509930655165996.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: joe@perches.com, netdev@vger.kernel.org, arkadis@mellanox.com, idosch@mellanox.com, mlxsw@mellanox.com To: David Miller Return-path: Received: from mail-wr0-f176.google.com ([209.85.128.176]:34034 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097AbdLSQRi (ORCPT ); Tue, 19 Dec 2017 11:17:38 -0500 Received: by mail-wr0-f176.google.com with SMTP id y21so19807828wrc.1 for ; Tue, 19 Dec 2017 08:17:37 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171219.110906.560509930655165996.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Tue, Dec 19, 2017 at 05:09:06PM CET, davem@davemloft.net wrote: >From: Joe Perches >Date: Sun, 17 Dec 2017 08:25:00 -0800 > >> On Sun, 2017-12-17 at 17:15 +0100, Jiri Pirko wrote: >>> From: Arkadi Sharshevsky >>> >>> Add "spectrum" string prefix macro for error strings. >> [] >>> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c >> [] >>> @@ -4168,13 +4168,11 @@ mlxsw_sp_master_lag_check(struct mlxsw_sp *mlxsw_sp, >>> u16 lag_id; >>> >>> if (mlxsw_sp_lag_index_get(mlxsw_sp, lag_dev, &lag_id) != 0) { >>> - NL_SET_ERR_MSG(extack, >>> - "spectrum: Exceeded number of supported LAG devices"); >>> + NL_SET_ERR_MSG(extack, MLXSW_SP_PREFIX "Exceeded number of supported LAG devices"); >> >> Perhaps use NL_SET_ERR_MSG_MOD instead. > >Yeah that probably makes sense. Yes. Thanks