From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available Date: Tue, 19 Dec 2017 17:47:07 +0200 Message-ID: <20171219174259-mutt-send-email-mst@kernel.org> References: <1513644036-45230-1-git-send-email-sridhar.samudrala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: stephen@networkplumber.org, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, alexander.duyck@gmail.com To: Sridhar Samudrala Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52506 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbdLSPrI (ORCPT ); Tue, 19 Dec 2017 10:47:08 -0500 Content-Disposition: inline In-Reply-To: <1513644036-45230-1-git-send-email-sridhar.samudrala@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: I'll need to look at this more, in particular the feature bit is missing here. For now one question: On Mon, Dec 18, 2017 at 04:40:36PM -0800, Sridhar Samudrala wrote: > @@ -56,6 +58,8 @@ module_param(napi_tx, bool, 0644); > */ > DECLARE_EWMA(pkt_len, 0, 64) > > +#define VF_TAKEOVER_INT (HZ / 10) > + > #define VIRTNET_DRIVER_VERSION "1.0.0" > > static const unsigned long guest_offloads[] = { Why is this delay necessary? And why by 100ms?