From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH net-next v2] netdevsim: correctly check return value of debugfs_create_dir Date: Tue, 19 Dec 2017 18:34:37 -0800 Message-ID: <20171219183437.4b75dc10@cakuba.netronome.com> References: <20171220022715.2356-1-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , netdev@vger.kernel.org To: Prashant Bhole Return-path: Received: from mail-qt0-f194.google.com ([209.85.216.194]:40627 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752867AbdLTCel (ORCPT ); Tue, 19 Dec 2017 21:34:41 -0500 Received: by mail-qt0-f194.google.com with SMTP id u42so26670209qte.7 for ; Tue, 19 Dec 2017 18:34:40 -0800 (PST) In-Reply-To: <20171220022715.2356-1-bhole_prashant_q7@lab.ntt.co.jp> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 20 Dec 2017 11:27:15 +0900, Prashant Bhole wrote: > diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c > index eb8c679fca9f..c2a02d1944b8 100644 > --- a/drivers/net/netdevsim/netdev.c > +++ b/drivers/net/netdevsim/netdev.c > @@ -147,10 +147,12 @@ struct device_type nsim_dev_type = { > static int nsim_init(struct net_device *dev) > { > struct netdevsim *ns = netdev_priv(dev); > - int err; > + int err = -ENOMEM; > > ns->netdev = dev; > ns->ddir = debugfs_create_dir(netdev_name(dev), nsim_ddir); > + if (IS_ERR_OR_NULL(ns->ddir)) > + goto err; nit: Could you return err; here directly instead of go(ing )to return and having label and variable of the same name? Same in nsim_module_init(). With that feel free to add: Acked-by: Jakub Kicinski Thanks! > err = nsim_bpf_init(ns); > if (err) > @@ -171,6 +173,7 @@ static int nsim_init(struct net_device *dev) > nsim_bpf_uninit(ns); > err_debugfs_destroy: > debugfs_remove_recursive(ns->ddir); > +err: > return err; > } >