From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: [PATCH net 0/2] cls_bpf: fix offload state tracking with block callbacks Date: Tue, 19 Dec 2017 13:32:12 -0800 Message-ID: <20171219213214.1084-1-jakub.kicinski@netronome.com> Cc: daniel@iogearbox.net, jiri@resnulli.us, oss-drivers@netronome.com, Jakub Kicinski To: netdev@vger.kernel.org Return-path: Received: from mail-pl0-f65.google.com ([209.85.160.65]:33293 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155AbdLSVcZ (ORCPT ); Tue, 19 Dec 2017 16:32:25 -0500 Received: by mail-pl0-f65.google.com with SMTP id 1so6303596plv.0 for ; Tue, 19 Dec 2017 13:32:25 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: Hi! After introduction of block callbacks classifiers can no longer track offload state. cls_bpf used to do that in an attempt to move common code from drivers to the core. Remove that functionality and fix drivers. The user-visible bug this is fixing is that trying to offload a second filter would trigger a spurious DESTROY and in turn disable the already installed one. Jakub Kicinski (2): cls_bpf: fix offload assumptions after callback conversion nfp: bpf: keep track of the offloaded program drivers/net/ethernet/netronome/nfp/bpf/main.c | 55 ++++++++++++---- drivers/net/ethernet/netronome/nfp/bpf/main.h | 8 +++ include/net/pkt_cls.h | 5 +- net/sched/cls_bpf.c | 93 +++++++++++---------------- 4 files changed, 92 insertions(+), 69 deletions(-) -- 2.15.1