From: David Miller <davem@davemloft.net>
To: gregkh@linuxfoundation.org
Cc: andriy.shevchenko@linux.intel.com, netdev@vger.kernel.org,
Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
devel@driverdev.osuosl.org
Subject: Re: [PATCH v1 2/4] lib/net_utils: Introduce mac_pton_from_user()
Date: Wed, 20 Dec 2017 10:51:21 -0500 (EST) [thread overview]
Message-ID: <20171220.105121.1237351247624599520.davem@davemloft.net> (raw)
In-Reply-To: <20171220071355.GB1957@kroah.com>
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Wed, 20 Dec 2017 08:13:55 +0100
> On Tue, Dec 19, 2017 at 09:14:10PM +0200, Andy Shevchenko wrote:
>> Some drivers are getting MAC from user space. Make a helper for them.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> include/linux/kernel.h | 1 +
>> lib/net_utils.c | 12 ++++++++++++
>> 2 files changed, 13 insertions(+)
>
> Don't do this just for some horrid staging drivers. They can just drop
> that functionality entirely and use the "normal" way of doing this if
> they really want it.
Agreed.
next prev parent reply other threads:[~2017-12-20 15:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 19:14 [PATCH v1 1/4] lib/net_utils: Relax NULL-termination requirement on input string Andy Shevchenko
2017-12-19 19:14 ` [PATCH v1 2/4] lib/net_utils: Introduce mac_pton_from_user() Andy Shevchenko
2017-12-20 7:13 ` Greg Kroah-Hartman
2017-12-20 15:51 ` David Miller [this message]
2017-12-19 19:14 ` [PATCH v1 3/4] staging: rtl8723bs: Replace mac address parsing Andy Shevchenko
2017-12-19 19:14 ` [PATCH v1 4/4] staging: rtl8712: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220.105121.1237351247624599520.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Larry.Finger@lwfinger.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).