From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v1 2/4] lib/net_utils: Introduce mac_pton_from_user() Date: Wed, 20 Dec 2017 10:51:21 -0500 (EST) Message-ID: <20171220.105121.1237351247624599520.davem@davemloft.net> References: <20171219191412.14880-1-andriy.shevchenko@linux.intel.com> <20171219191412.14880-2-andriy.shevchenko@linux.intel.com> <20171220071355.GB1957@kroah.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andriy.shevchenko@linux.intel.com, netdev@vger.kernel.org, Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, devel@driverdev.osuosl.org To: gregkh@linuxfoundation.org Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:39444 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755528AbdLTPv0 (ORCPT ); Wed, 20 Dec 2017 10:51:26 -0500 In-Reply-To: <20171220071355.GB1957@kroah.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Greg Kroah-Hartman Date: Wed, 20 Dec 2017 08:13:55 +0100 > On Tue, Dec 19, 2017 at 09:14:10PM +0200, Andy Shevchenko wrote: >> Some drivers are getting MAC from user space. Make a helper for them. >> >> Signed-off-by: Andy Shevchenko >> --- >> include/linux/kernel.h | 1 + >> lib/net_utils.c | 12 ++++++++++++ >> 2 files changed, 13 insertions(+) > > Don't do this just for some horrid staging drivers. They can just drop > that functionality entirely and use the "normal" way of doing this if > they really want it. Agreed.