From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] qed*: Utilize FW 8.33.1.0
Date: Wed, 20 Dec 2017 11:54:03 -0500 (EST)
Message-ID: <20171220.115403.2203972051867900874.davem@davemloft.net>
References: <1513692323-26684-1-git-send-email-Tomer.Tayar@cavium.com>
        <20171219154651.30930d2a@cakuba.netronome.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: Tomer.Tayar@cavium.com, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org,
        Ariel.Elior@cavium.com, Michal.Kalderon@cavium.com,
        Yuval.Bason@cavium.com, Ram.Amrani@cavium.com,
        Manish.Chopra@cavium.com, Chad.Dupuis@cavium.com,
        Manish.Rangankar@cavium.com
To: jakub.kicinski@netronome.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:40334 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755496AbdLTQyE (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 20 Dec 2017 11:54:04 -0500
In-Reply-To: <20171219154651.30930d2a@cakuba.netronome.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue, 19 Dec 2017 15:46:51 -0800

> On Tue, 19 Dec 2017 16:05:23 +0200, Tomer Tayar wrote:
>> Sorry for the very long patch.
>> The firmware changes are spread all over w/o a good modularity.
> 
> Rings false.  Significant portion of this patch is just whitespace 
> and comment changes.

Totally agreed.

This thing is beyond huge already, adding unrelated whitespace and
comment changes make reviewing it even more impossible.