From: David Miller <davem@davemloft.net>
To: cugyly@163.com
Cc: netdev@vger.kernel.org, Linyu.Yuan@alcatel-sbell.com.cn
Subject: Re: [PATCH net-next] net: packet: allow bind to device which is !IFF_UP
Date: Wed, 20 Dec 2017 15:06:56 -0500 (EST) [thread overview]
Message-ID: <20171220.150656.1052155984496301218.davem@davemloft.net> (raw)
In-Reply-To: <1513776049-9141-1-git-send-email-cugyly@163.com>
From: yuan linyu <cugyly@163.com>
Date: Wed, 20 Dec 2017 21:20:49 +0800
> From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
>
> this try to allow tcpdump to capture packet once device IFF_UP
>
> Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
I don't think this is such a great idea.
Even if it "works":
1) The behavior goes back decades, this means real applications can
be broken by this change.
2) The feedback is useful, if I ran tcpdump on the wrong interface
I'd like to get this error if the interface I mistakenly chose
was done in order to help me figure this out.
prev parent reply other threads:[~2017-12-20 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 13:20 [PATCH net-next] net: packet: allow bind to device which is !IFF_UP yuan linyu
2017-12-20 20:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220.150656.1052155984496301218.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=cugyly@163.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox