From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Rong Subject: [PATCH] selftests/bpf: remove the DEBUG macro for test_dev_cgroup Date: Wed, 20 Dec 2017 11:15:44 +0800 Message-ID: <20171220031544.13350-1-chenr.fnst@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , Alexei Starovoitov , Daniel Borkmann , Shuah Khan , , , To: unlisted-recipients:; (no To-header on input) Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org The test may fail if not enable DEBUG macro in dev_cgroup.c # ./test_dev_cgroup libbpf: load bpf program failed: Operation not permitted libbpf: failed to load program 'cgroup/dev' libbpf: failed to load object './dev_cgroup.o' Failed to load DEV_CGROUP program Removing the DEBUG macro makes the test always pass. Signed-off-by: Chen Rong --- tools/testing/selftests/bpf/dev_cgroup.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/testing/selftests/bpf/dev_cgroup.c b/tools/testing/selftests/bpf/dev_cgroup.c index ce41a34..a167c6d 100644 --- a/tools/testing/selftests/bpf/dev_cgroup.c +++ b/tools/testing/selftests/bpf/dev_cgroup.c @@ -13,7 +13,6 @@ SEC("cgroup/dev") int bpf_prog1(struct bpf_cgroup_dev_ctx *ctx) { short type = ctx->access_type & 0xFFFF; -#ifdef DEBUG short access = ctx->access_type >> 16; char fmt[] = " %d:%d \n"; @@ -39,7 +38,6 @@ int bpf_prog1(struct bpf_cgroup_dev_ctx *ctx) fmt[10] = 'm'; bpf_trace_printk(fmt, sizeof(fmt), ctx->major, ctx->minor); -#endif /* Allow access to /dev/zero and /dev/random. * Forbid everything else. -- 2.5.0