From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net 1/2] cls_bpf: fix offload assumptions after callback conversion Date: Wed, 20 Dec 2017 07:05:39 +0100 Message-ID: <20171220060539.GA1916@nanopsycho> References: <20171219213214.1084-1-jakub.kicinski@netronome.com> <20171219213214.1084-2-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, daniel@iogearbox.net, oss-drivers@netronome.com To: Jakub Kicinski Return-path: Received: from mail-wr0-f176.google.com ([209.85.128.176]:41854 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbdLTGFl (ORCPT ); Wed, 20 Dec 2017 01:05:41 -0500 Received: by mail-wr0-f176.google.com with SMTP id p69so12444782wrb.8 for ; Tue, 19 Dec 2017 22:05:40 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171219213214.1084-2-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: Tue, Dec 19, 2017 at 10:32:13PM CET, jakub.kicinski@netronome.com wrote: >cls_bpf used to take care of tracking what offload state a filter >is in, i.e. it would track if offload request succeeded or not. >This information would then be used to issue correct requests to >the driver, e.g. requests for statistics only on offloaded filters, >removing only filters which were offloaded, using add instead of >replace if previous filter was not added etc. > >This tracking of offload state no longer functions with the new >callback infrastructure. There could be multiple entities trying >to offload the same filter. > >Throw out all the tracking and corresponding commands and simply >pass to the drivers both old and new bpf program. Drivers will >have to deal with offload state tracking by themselves. > >Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload") >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko Thanks Jakub!