From: Stephen Hemminger <stephen@networkplumber.org>
To: Chris Mi <chrism@mellanox.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gerlitz.or@gmail.com" <gerlitz.or@gmail.com>
Subject: Re: [patch iproute2] tc: add -bs option for batch mode
Date: Wed, 20 Dec 2017 07:17:44 -0800 [thread overview]
Message-ID: <20171220071744.25f9dd41@xeon-e3> (raw)
In-Reply-To: <VI1PR0501MB21433CE21CEF8212A8BBE21AAB0C0@VI1PR0501MB2143.eurprd05.prod.outlook.com>
On Wed, 20 Dec 2017 09:23:34 +0000
Chris Mi <chrism@mellanox.com> wrote:
> > Your real performance win is just not asking for ACK for every rule.
> No. Even if batch_size > 1, we ack every rule. The real performance win is
> to send multiple rules in one system call. If we are not asking for ACK for every rule,
> the performance will be improved further.
Try the no ACK method.
When we were optimizing routing daemons like Quagga, it was discovered
that an ACK for every route insert was the main bottleneck. Doing asynchronous
error handling got a bigger win than your batching.
Please try that, doing multiple messages using iov is not necessary.
next prev parent reply other threads:[~2017-12-20 15:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 6:33 [patch iproute2] tc: add -bs option for batch mode Chris Mi
2017-12-19 15:15 ` Stephen Hemminger
2017-12-20 8:47 ` Or Gerlitz
2017-12-19 15:22 ` Stephen Hemminger
2017-12-20 9:23 ` Chris Mi
2017-12-20 15:17 ` Stephen Hemminger [this message]
2017-12-21 0:13 ` David Ahern
2017-12-21 1:30 ` Chris Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220071744.25f9dd41@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=chrism@mellanox.com \
--cc=gerlitz.or@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).