netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Wunderlich <sw@simonwunderlich.de>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	Sven Eckelmann <sven@narfation.org>,
	Simon Wunderlich <sw@simonwunderlich.de>
Subject: [PATCH 16/19] batman-adv: Add kernel-doc to structs in headers
Date: Wed, 20 Dec 2017 12:01:21 +0100	[thread overview]
Message-ID: <20171220110124.13117-17-sw@simonwunderlich.de> (raw)
In-Reply-To: <20171220110124.13117-1-sw@simonwunderlich.de>

From: Sven Eckelmann <sven@narfation.org>

All structs in types.h are already documented. But some other headers
still have private structs which also should be documented.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
---
 net/batman-adv/hash.h  | 14 +++++++++++---
 net/batman-adv/sysfs.h | 13 +++++++++++++
 2 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/net/batman-adv/hash.h b/net/batman-adv/hash.h
index c92fde593959..65396b126f3b 100644
--- a/net/batman-adv/hash.h
+++ b/net/batman-adv/hash.h
@@ -46,10 +46,18 @@ typedef bool (*batadv_hashdata_compare_cb)(const struct hlist_node *,
 typedef u32 (*batadv_hashdata_choose_cb)(const void *, u32);
 typedef void (*batadv_hashdata_free_cb)(struct hlist_node *, void *);
 
+/**
+ * struct batadv_hashtable - Wrapper of simple hlist based hashtable
+ */
 struct batadv_hashtable {
-	struct hlist_head *table;   /* the hashtable itself with the buckets */
-	spinlock_t *list_locks;     /* spinlock for each hash list entry */
-	u32 size;		    /* size of hashtable */
+	/** @table: the hashtable itself with the buckets */
+	struct hlist_head *table;
+
+	/** @list_locks: spinlock for each hash list entry */
+	spinlock_t *list_locks;
+
+	/** @size: size of hashtable */
+	u32 size;
 };
 
 /* allocates and clears the hash */
diff --git a/net/batman-adv/sysfs.h b/net/batman-adv/sysfs.h
index 0384cb6c406b..bbeee61221fa 100644
--- a/net/batman-adv/sysfs.h
+++ b/net/batman-adv/sysfs.h
@@ -36,10 +36,23 @@ struct net_device;
  */
 #define BATADV_SYSFS_VLAN_SUBDIR_PREFIX "vlan"
 
+/**
+ * struct batadv_attribute - sysfs export helper for batman-adv attributes
+ */
 struct batadv_attribute {
+	/** @attr: sysfs attribute file */
 	struct attribute attr;
+
+	/**
+	 * @show: function to export the current attribute's content to sysfs
+	 */
 	ssize_t (*show)(struct kobject *kobj, struct attribute *attr,
 			char *buf);
+
+	/**
+	 * @store: function to load new value from character buffer and save it
+	 * in batman-adv attribute
+	 */
 	ssize_t (*store)(struct kobject *kobj, struct attribute *attr,
 			 char *buf, size_t count);
 };
-- 
2.11.0

  parent reply	other threads:[~2017-12-20 11:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-20 11:01 [PATCH 00/19] pull request for net-next: batman-adv 2017-12-20 Simon Wunderlich
2017-12-20 11:01 ` [PATCH 01/19] batman-adv: Start new development cycle Simon Wunderlich
2017-12-20 11:01 ` [PATCH 02/19] batman-adv: Deinline batadv_orig_hash_find, save 7339 bytes Simon Wunderlich
2017-12-20 11:01 ` [PATCH 03/19] batman-adv: Add SPDX license identifier above copyright header Simon Wunderlich
2017-12-20 11:01 ` [PATCH 04/19] batman-adv: Add SPDX license identifier to batman-adv.rst Simon Wunderlich
2017-12-20 11:01 ` [PATCH 09/19] batman-adv: Include net.h for net_ratelimited_function Simon Wunderlich
     [not found] ` <20171220110124.13117-1-sw-2YrNx6rUIHYiY0qSoAWiAoQuADTiUCJX@public.gmane.org>
2017-12-20 11:01   ` [PATCH 05/19] batman-adv: Add license header to Kconfig Simon Wunderlich
2017-12-20 11:01   ` [PATCH 06/19] batman-adv: Change batman_adv.h license to MIT Simon Wunderlich
2017-12-20 11:01   ` [PATCH 07/19] batman-adv: include gfp.h for GFP_* defines Simon Wunderlich
2017-12-20 11:01   ` [PATCH 08/19] batman-adv: include build_bug.h for BUILD_BUG_ON define Simon Wunderlich
2017-12-20 11:01   ` [PATCH 10/19] batman-adv: include kobject.h for kobject_* functions Simon Wunderlich
2017-12-20 11:01 ` [PATCH 11/19] batman-adv: Remove unused sched.h include Simon Wunderlich
2017-12-20 11:01 ` [PATCH 12/19] batman-adv: Add missing kernel-doc to packet.h Simon Wunderlich
2017-12-20 11:01 ` [PATCH 13/19] batman-adv: Use parentheses in function kernel-doc Simon Wunderlich
2017-12-20 11:01 ` [PATCH 14/19] batman-adv: Use inline kernel-doc for enum/struct Simon Wunderlich
2017-12-20 11:01 ` [PATCH 15/19] batman-adv: Fix kernel-doc references to struct members Simon Wunderlich
2017-12-20 11:01 ` Simon Wunderlich [this message]
2017-12-20 11:01 ` [PATCH 17/19] batman-adv: Add kernel-doc to enums in headers Simon Wunderlich
2017-12-20 11:01 ` [PATCH 18/19] batman-adv: Add kernel-doc to functions " Simon Wunderlich
2017-12-20 11:01 ` [PATCH 19/19] batman-adv: Add kernel-doc to externally visible functions Simon Wunderlich
2017-12-20 19:39 ` [PATCH 00/19] pull request for net-next: batman-adv 2017-12-20 David Miller
2017-12-21  5:58   ` [B.A.T.M.A.N.] " Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171220110124.13117-17-sw@simonwunderlich.de \
    --to=sw@simonwunderlich.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).