From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gospodarek Subject: Re: [PATCH v1] net: bonding: Replace mac address parsing Date: Wed, 20 Dec 2017 09:25:46 -0500 Message-ID: <20171220142546.GA52560@C02RW35GFVH8.dhcp.broadcom.net> References: <20171219182044.5678-1-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jay Vosburgh , Veaceslav Falico , netdev@vger.kernel.org To: Andy Shevchenko Return-path: Received: from mail-qt0-f193.google.com ([209.85.216.193]:42878 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754664AbdLTOZv (ORCPT ); Wed, 20 Dec 2017 09:25:51 -0500 Received: by mail-qt0-f193.google.com with SMTP id g9so28453001qth.9 for ; Wed, 20 Dec 2017 06:25:51 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171219182044.5678-1-andriy.shevchenko@linux.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Dec 19, 2017 at 08:20:44PM +0200, Andy Shevchenko wrote: > Replace sscanf() with mac_pton(). > > Signed-off-by: Andy Shevchenko Nice cleanup. Thanks! Acked-by: Andy Gospodarek > --- > drivers/net/bonding/bond_options.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c > index 8a9b085c2a98..58c705f24f96 100644 > --- a/drivers/net/bonding/bond_options.c > +++ b/drivers/net/bonding/bond_options.c > @@ -1431,13 +1431,9 @@ static int bond_option_ad_actor_system_set(struct bonding *bond, > { > u8 macaddr[ETH_ALEN]; > u8 *mac; > - int i; > > if (newval->string) { > - i = sscanf(newval->string, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx", > - &macaddr[0], &macaddr[1], &macaddr[2], > - &macaddr[3], &macaddr[4], &macaddr[5]); > - if (i != ETH_ALEN) > + if (!mac_pton(newval->string, macaddr)) > goto err; > mac = macaddr; > } else { > -- > 2.15.1 >