From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net v2] ipv4: Fix use-after-free when flushing FIB tables
Date: Wed, 20 Dec 2017 19:41:17 +0200
Message-ID: <20171220174117.GA11654@splinter>
References: <20171220085156.27991-1-idosch@mellanox.com>
 <CAKgT0UcJD=OYM5qEdGv-vvpv3EcAyRVTWJ34MWshrxABvFUWGw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Ido Schimmel <idosch@mellanox.com>,
        Netdev <netdev@vger.kernel.org>,
        David Miller <davem@davemloft.net>,
        "Duyck, Alexander H" <alexander.h.duyck@intel.com>,
        David Ahern <dsahern@gmail.com>,
        Fengguang Wu <fengguang.wu@intel.com>, mlxsw@mellanox.com
To: Alexander Duyck <alexander.duyck@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:57271 "EHLO
        out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1755636AbdLTRlU (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 20 Dec 2017 12:41:20 -0500
Content-Disposition: inline
In-Reply-To: <CAKgT0UcJD=OYM5qEdGv-vvpv3EcAyRVTWJ34MWshrxABvFUWGw@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Dec 20, 2017 at 07:32:21AM -0800, Alexander Duyck wrote:
> I think we might want even more description here. Specifically why
> reversing the order allows local to be destroyed before main. I was
> thinking something along the lines of:
> 
> Destroy the tables in reverse order to guarantee that the local table,
> ID 255, is destroyed before main table, ID 254. This is necessary as
> local may contain references to data contained in main.

Sent v3:
http://patchwork.ozlabs.org/patch/851564/

Thanks