From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Garver <e@erig.me>
Subject: Re: [PATCH net v2] openvswitch: Fix pop_vlan action for double
 tagged frames
Date: Wed, 20 Dec 2017 13:13:41 -0500
Message-ID: <20171220181341.GG25853@dev-rhel7>
References: <20171220153932.1362-1-e@erig.me>
 <20171220184117.19dfa575@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, ovs-dev@openvswitch.org
To: Jiri Benc <jbenc@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:35598 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755816AbdLTSNh (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 20 Dec 2017 13:13:37 -0500
Content-Disposition: inline
In-Reply-To: <20171220184117.19dfa575@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Dec 20, 2017 at 06:41:17PM +0100, Jiri Benc wrote:
> On Wed, 20 Dec 2017 10:39:32 -0500, Eric Garver wrote:
> > +	if (is_flow_key_valid(key) && key->eth.vlan.tci && key->eth.cvlan.tci)
> 
> Maybe (key->eth.vlan.tci & htons(VLAN_TAG_PRESENT)) for consistency
> with the rest of the code? But it's just nitpicking.
> 
> The real problem here is when a double tagged packet leaves the ovs
> bridge, it won't have the skb->protocol that the kernel expects: it
> will be ethertype of the payload, while my understanding is it should
> be the inner tpid, right?

Right.

> 
> This patch fixes that nicely for the pop vlan case. But what about
> other cases? It seems to me that we need to add the logic to
> key_extract.
> 

The part I was missing is; before encap into the L3 tunnel all the VLAN
tags must be explicitly popped.

Setting skb->protocol to the TPID for double tagged frames means the pop
operations shift the payload ethertype into skb->protocol.

I'll send a v3 that does this is key_extract().