From: Jiri Benc <jbenc@redhat.com>
To: Eric Garver <e@erig.me>
Cc: netdev@vger.kernel.org, ovs-dev@openvswitch.org
Subject: Re: [PATCH net v2] openvswitch: Fix pop_vlan action for double tagged frames
Date: Wed, 20 Dec 2017 18:41:17 +0100 [thread overview]
Message-ID: <20171220184117.19dfa575@redhat.com> (raw)
In-Reply-To: <20171220153932.1362-1-e@erig.me>
On Wed, 20 Dec 2017 10:39:32 -0500, Eric Garver wrote:
> + if (is_flow_key_valid(key) && key->eth.vlan.tci && key->eth.cvlan.tci)
Maybe (key->eth.vlan.tci & htons(VLAN_TAG_PRESENT)) for consistency
with the rest of the code? But it's just nitpicking.
The real problem here is when a double tagged packet leaves the ovs
bridge, it won't have the skb->protocol that the kernel expects: it
will be ethertype of the payload, while my understanding is it should
be the inner tpid, right?
This patch fixes that nicely for the pop vlan case. But what about
other cases? It seems to me that we need to add the logic to
key_extract.
Thanks!
Jiri
next prev parent reply other threads:[~2017-12-20 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 15:39 [PATCH net v2] openvswitch: Fix pop_vlan action for double tagged frames Eric Garver
2017-12-20 17:41 ` Jiri Benc [this message]
2017-12-20 18:13 ` Eric Garver
2017-12-20 17:41 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220184117.19dfa575@redhat.com \
--to=jbenc@redhat.com \
--cc=e@erig.me \
--cc=netdev@vger.kernel.org \
--cc=ovs-dev@openvswitch.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).