From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:45268 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755669AbdLTRlV (ORCPT ); Wed, 20 Dec 2017 12:41:21 -0500 Date: Wed, 20 Dec 2017 18:41:17 +0100 From: Jiri Benc To: Eric Garver Cc: netdev@vger.kernel.org, ovs-dev@openvswitch.org Subject: Re: [PATCH net v2] openvswitch: Fix pop_vlan action for double tagged frames Message-ID: <20171220184117.19dfa575@redhat.com> In-Reply-To: <20171220153932.1362-1-e@erig.me> References: <20171220153932.1362-1-e@erig.me> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 20 Dec 2017 10:39:32 -0500, Eric Garver wrote: > + if (is_flow_key_valid(key) && key->eth.vlan.tci && key->eth.cvlan.tci) Maybe (key->eth.vlan.tci & htons(VLAN_TAG_PRESENT)) for consistency with the rest of the code? But it's just nitpicking. The real problem here is when a double tagged packet leaves the ovs bridge, it won't have the skb->protocol that the kernel expects: it will be ethertype of the payload, while my understanding is it should be the inner tpid, right? This patch fixes that nicely for the pop vlan case. But what about other cases? It seems to me that we need to add the logic to key_extract. Thanks! Jiri