From: Jakub Kicinski <kubakici@wp.pl>
To: Siwei Liu <loseweigh@gmail.com>
Cc: mst@redhat.com, sridhar.samudrala@intel.com,
alexander.duyck@gmail.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available
Date: Wed, 20 Dec 2017 20:52:04 -0800 [thread overview]
Message-ID: <20171220205204.4853f1d1@cakuba.netronome.com> (raw)
In-Reply-To: <CADGSJ22mDyC0Sw2EPW96ZWvMPLnzif+Y9MMouhM-6T03ZaKA0Q@mail.gmail.com>
On Wed, 20 Dec 2017 18:16:30 -0800, Siwei Liu wrote:
> > The plan is to remove the delay and do the naming in the kernel.
> > This was suggested by Lennart since udev is only doing naming policy
> > because kernel names were not repeatable.
> >
> > This makes the VF show up as "ethN_vf" on Hyper-V which is user friendly.
> >
> > Patch is pending.
>
> While it's good to show VF with specific naming to indicate
> enslavement, I wonder wouldn't it be better to hide this netdev at all
> from the user space? IMHO this extra device is useless when being
> enslaved and we may delegate controls (e.g. ethtool) over to the
> para-virtual device instead? That way it's possible to eliminate the
> possibility of additional udev setup or modification?
>
> I'm not sure if this is consistent with Windows guest or not, but I
> don't find it _Linux_ user friendly that ethtool doesn't work on the
> composite interface any more, and I have to end up with finding out
> the correct enslaved VF I must operate on.
Hiding "low level" netdevs comes up from time to time, and is more
widely applicable than just to VF bonds. We should find a generic
solution to that problem.
next prev parent reply other threads:[~2017-12-21 4:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 0:40 [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
2017-12-19 15:47 ` Michael S. Tsirkin
2017-12-19 17:41 ` Samudrala, Sridhar
2017-12-19 17:55 ` Stephen Hemminger
2017-12-19 18:07 ` Michael S. Tsirkin
2017-12-19 18:13 ` Stephen Hemminger
2017-12-19 18:21 ` David Miller
2017-12-19 18:41 ` Stephen Hemminger
2017-12-19 19:42 ` Samudrala, Sridhar
2017-12-19 19:46 ` Stephen Hemminger
2017-12-19 22:37 ` Samudrala, Sridhar
2017-12-19 22:53 ` Stephen Hemminger
2017-12-20 0:26 ` Samudrala, Sridhar
2017-12-21 1:31 ` Siwei Liu
2017-12-21 2:16 ` Siwei Liu
2017-12-21 4:52 ` Jakub Kicinski [this message]
2017-12-22 8:42 ` Siwei Liu
2017-12-19 18:20 ` David Miller
2017-12-20 10:51 ` Vitaly Kuznetsov
2017-12-20 22:33 ` Jakub Kicinski
2017-12-21 0:15 ` Michael S. Tsirkin
2017-12-21 0:29 ` Jakub Kicinski
2017-12-21 0:14 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220205204.4853f1d1@cakuba.netronome.com \
--to=kubakici@wp.pl \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=loseweigh@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).