From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:49420 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932479AbdLTURS (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 20 Dec 2017 15:17:18 -0500
Date: Wed, 20 Dec 2017 21:17:15 +0100
From: Jiri Benc <jbenc@redhat.com>
To: Eric Garver <e@erig.me>
Cc: netdev@vger.kernel.org, ovs-dev@openvswitch.org
Subject: Re: [PATCH net v3] openvswitch: Fix pop_vlan action for double
 tagged frames
Message-ID: <20171220211715.22b4c4e6@redhat.com>
In-Reply-To: <20171220200922.29415-1-e@erig.me>
References: <20171220200922.29415-1-e@erig.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 20 Dec 2017 15:09:22 -0500, Eric Garver wrote:
> skb_vlan_pop() expects skb->protocol to be a valid TPID for double
> tagged frames. So set skb->protocol to the TPID and let skb_vlan_pop()
> shift the true ethertype into position for us.
> 
> Fixes: 5108bbaddc37 ("openvswitch: add processing of L3 packets")
> Signed-off-by: Eric Garver <e@erig.me>

Thanks!

Reviewed-by: Jiri Benc <jbenc@redhat.com>