From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: David Miller <davem@davemloft.net>,
mingo@kernel.org, ian.mcdonald@jandi.co.nz, vyasevich@gmail.com,
stephen@networkplumber.org, peterz@infradead.org,
tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com,
gerrit@erg.abdn.ac.uk, nhorman@tuxdriver.com,
dccp@vger.kernel.org, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, sfr@canb.auug.org.au
Subject: Re: [PATCH net-next v4 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events
Date: Wed, 20 Dec 2017 22:12:38 -0500 [thread overview]
Message-ID: <20171220221238.2b0a9fa1@vmware.local.home> (raw)
In-Reply-To: <20171221113657.f25b2f61eb472579ab32132d@kernel.org>
On Thu, 21 Dec 2017 11:36:57 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> On Wed, 20 Dec 2017 14:24:24 -0500 (EST)
> David Miller <davem@davemloft.net> wrote:
>
> > From: David Miller <davem@davemloft.net>
> > Date: Wed, 20 Dec 2017 14:20:40 -0500 (EST)
> >
> > > From: Masami Hiramatsu <mhiramat@kernel.org>
> > > Date: Wed, 20 Dec 2017 13:14:11 +0900
> > >
> > >> This series is v4 of the replacement of jprobe usage with trace
> > >> events. This version is rebased on net-next, fixes a build warning
> > >> and moves a temporal variable definition in a block.
> > >>
> > >> Previous version is here;
> > >> https://lkml.org/lkml/2017/12/19/153
> > >>
> > >> Changes from v3:
> > >> All: Rebased on net-next
> > >> [3/6]: fixes a build warning for i386 by casting pointer unsigned
> > >> long instead of __u64, and moves a temporal variable
> > >> definition in a block.
> > >
> > > Looks good, series applied to net-next, thanks.
> >
> > Actually, this doesn't even compile, so I've reverted:
> >
> > [davem@dhcp-10-15-49-227 net-next]$ make -s -j16
> > In file included from net/dccp/trace.h:105:0,
> > from net/dccp/proto.c:42:
> > ./include/trace/define_trace.h:89:42: fatal error: ./trace.h: No such file or directory
> > #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> > ^
> > compilation terminated.
>
> Hi David,
>
> Could you share your .config file? I would like to reproduce it.
> When I tried with attached kconfig, I could not reproduce this issue,
> and could run it.
>
Hi Masami,
Are you sure you committed everything in this change set? I don't see a
modification of the Makefile to get the trace.h file you created.
Shouldn't there be something like:
CFLAGS_proto.o := -I$(src)
in the Makefile?
-- Steve
next prev parent reply other threads:[~2017-12-21 3:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 4:14 [PATCH net-next v4 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events Masami Hiramatsu
2017-12-20 4:14 ` [PATCH net-next v4 1/6] net: tcp: Add trace events for TCP congestion window tracing Masami Hiramatsu
2017-12-20 4:15 ` [PATCH net-next v4 2/6] net: tcp: Remove TCP probe module Masami Hiramatsu
2017-12-20 4:15 ` [PATCH net-next v4 3/6] net: sctp: Add SCTP ACK tracking trace event Masami Hiramatsu
2017-12-20 4:16 ` [PATCH net-next v4 4/6] net: sctp: Remove debug SCTP probe module Masami Hiramatsu
2017-12-20 4:16 ` [PATCH net-next v4 5/6] net: dccp: Add DCCP sendmsg trace event Masami Hiramatsu
2017-12-21 14:43 ` [PATCH net-next v4.1 " Masami Hiramatsu
2017-12-21 15:57 ` David Miller
2017-12-21 16:08 ` Steven Rostedt
2017-12-22 1:30 ` Masami Hiramatsu
2017-12-20 4:17 ` [PATCH net-next v4 6/6] net: dccp: Remove dccpprobe module Masami Hiramatsu
2017-12-20 19:20 ` [PATCH net-next v4 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events David Miller
2017-12-20 19:24 ` David Miller
2017-12-21 0:10 ` Masami Hiramatsu
2017-12-21 2:36 ` Masami Hiramatsu
2017-12-21 3:12 ` Steven Rostedt [this message]
2017-12-21 13:16 ` Masami Hiramatsu
2017-12-21 14:27 ` Masami Hiramatsu
2017-12-21 4:08 ` David Miller
2017-12-21 12:43 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220221238.2b0a9fa1@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=gerrit@erg.abdn.ac.uk \
--cc=hpa@zytor.com \
--cc=ian.mcdonald@jandi.co.nz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=stephen@networkplumber.org \
--cc=tglx@linutronix.de \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).