From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCH net] l2tp: fix missing print session offset info
Date: Fri, 22 Dec 2017 11:29:03 +0800
Message-ID: <20171222032903.GD13972@leo.usersys.redhat.com>
References: <1513838730-14033-1-git-send-email-liuhangbin@gmail.com>
 <20171221.150836.1128769335522894244.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, jchapman@katalix.com
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f51.google.com ([209.85.160.51]:37726 "EHLO
        mail-pl0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755367AbdLVD3O (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 21 Dec 2017 22:29:14 -0500
Received: by mail-pl0-f51.google.com with SMTP id s3so12212228plp.4
        for <netdev@vger.kernel.org>; Thu, 21 Dec 2017 19:29:14 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20171221.150836.1128769335522894244.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Dec 21, 2017 at 03:08:36PM -0500, David Miller wrote:
> From: Hangbin Liu <liuhangbin@gmail.com>
> Date: Thu, 21 Dec 2017 14:45:30 +0800
> 
> > +	    (session->offset &&
> > +	     nla_put_u16(skb, L2TP_ATTR_OFFSET, session->offset) ||
> 
> It really discourages people from reviewing your changes when they
> don't even compile.

Sh*t, I did compile and test my patch on the compiler. But forgot to the fix the
code on my laptop...Really sorry for this, I need to double check it before
send.