From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [Patch net] net_sched: fix a missing rcu barrier in
 mini_qdisc_pair_swap()
Date: Fri, 22 Dec 2017 10:38:06 +0100
Message-ID: <20171222093806.GB11519@nanopsycho>
References: <20171221072624.6204-1-xiyou.wangcong@gmail.com>
 <20171221090313.GB1930@nanopsycho>
 <CAM_iQpVfYUsJ6D5fpE+Ng8wGxK6uoN3PRntYO_Y0j+7YRKdSqg@mail.gmail.com>
 <CAM_iQpVyycftiydUi3VJsZ1QMj45dWDvkmsOquT10JqF-zrwkw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Jiri Pirko <jiri@mellanox.com>,
        John Fastabend <john.fastabend@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f175.google.com ([209.85.128.175]:46300 "EHLO
        mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757805AbdLVJiH (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 22 Dec 2017 04:38:07 -0500
Received: by mail-wr0-f175.google.com with SMTP id g17so18170154wrd.13
        for <netdev@vger.kernel.org>; Fri, 22 Dec 2017 01:38:07 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CAM_iQpVyycftiydUi3VJsZ1QMj45dWDvkmsOquT10JqF-zrwkw@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Thu, Dec 21, 2017 at 09:54:06PM CET, xiyou.wangcong@gmail.com wrote:
>On Thu, Dec 21, 2017 at 11:01 AM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>> On Thu, Dec 21, 2017 at 1:03 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>>>
>>>
>>> But again, we don't we just free qdisc in call_rcu and avoid the
>>> barrier?
>>
>>
>> Non-sense again. Why qdisc code should be adjusted for your
>> miniq code? It is your own responsibility to take care of this shit.
>> Don't spread it out of minq.
>
>Also, in case you believe call_rcu to free qdisc is queued after
>the call_rcu in miniq, you are wrong again:

I certainly don't :) Not sure why you think I do.

>
>https://www.kernel.org/pub/linux/kernel/people/paulmck/Answers/RCU/RCUCBordering.html
>
>The rcu callbacks don't guarantee FIFO ordering.