From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH RFC 09/18] r8168: use genphy_soft_reset instead of open
 coding the soft reset
Date: Fri, 22 Dec 2017 10:57:06 +0100
Message-ID: <20171222095706.GF2431@lunn.ch>
References: <83321b2e-8402-26c5-9703-3fe795cc893d@gmail.com>
 <13598591-49fe-0020-443e-9d6cedb53cfb@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
        Chun-Hao Lin <hau@realtek.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:42995 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1756918AbdLVJ5K (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 22 Dec 2017 04:57:10 -0500
Content-Disposition: inline
In-Reply-To: <13598591-49fe-0020-443e-9d6cedb53cfb@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Dec 21, 2017 at 09:50:28PM +0100, Heiner Kallweit wrote:
> Use genphy_soft_reset instead of open coding the soft reset.

Hi Heiner

At this point, you have swapped over the phylib. Does one of the
drivers in drivers/net/phy now take control of the PHY? Does the PHY
ID match one of those in realtek.c?

The PHY driver and phylib should be responsible for resetting the
PHY. The MAC driver should not need to do this.

     Andrew