From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH RFC 17/18] r8168: remove use of struct mii_if_info
Date: Fri, 22 Dec 2017 11:21:10 +0100
Message-ID: <20171222102110.GL2431@lunn.ch>
References: <83321b2e-8402-26c5-9703-3fe795cc893d@gmail.com>
 <335edd3a-0956-72c9-dbf2-4dfb992c69f7@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
        Chun-Hao Lin <hau@realtek.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:43048 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1758450AbdLVKVP (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 22 Dec 2017 05:21:15 -0500
Content-Disposition: inline
In-Reply-To: <335edd3a-0956-72c9-dbf2-4dfb992c69f7@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Dec 21, 2017 at 09:50:52PM +0100, Heiner Kallweit wrote:
> @@ -1188,21 +1188,6 @@ static void rtl_w0w1_phy(struct rtl8168_private *tp, int reg_addr, int p, int m)
>  	rtl_writephy(tp, reg_addr, (val & ~m) | p);
>  }
>  
> -static void rtl_mdio_write(struct net_device *dev, int phy_id, int location,
> -			   int val)
> -{
> -	struct rtl8168_private *tp = netdev_priv(dev);
> -
> -	rtl_writephy(tp, location, val);
> -}
> -
> -static int rtl_mdio_read(struct net_device *dev, int phy_id, int location)
> -{
> -	struct rtl8168_private *tp = netdev_priv(dev);
> -
> -	return rtl_readphy(tp, location);
> -}

Hi Heiner

With these two gone, it would be nice to rename r8168_mdio_read_reg()
and r8168_mdio_write_reg() to rtl_mdio_read() and rtl_mdio_write().

    Andrew