netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Jiri Pirko <jiri@mellanox.com>,
	John Fastabend <john.fastabend@gmail.com>
Subject: Re: [Patch net] net_sched: fix a missing rcu barrier in mini_qdisc_pair_swap()
Date: Fri, 22 Dec 2017 11:23:52 +0100	[thread overview]
Message-ID: <20171222102352.GD11519@nanopsycho> (raw)
In-Reply-To: <CAM_iQpVfYUsJ6D5fpE+Ng8wGxK6uoN3PRntYO_Y0j+7YRKdSqg@mail.gmail.com>

Thu, Dec 21, 2017 at 08:01:35PM CET, xiyou.wangcong@gmail.com wrote:
>On Thu, Dec 21, 2017 at 1:03 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>> Thu, Dec 21, 2017 at 08:26:24AM CET, xiyou.wangcong@gmail.com wrote:

[...]

>
>
>Seriously? It is this call_rcu still flying after we free the qdisc.
>Did you seriously look into the stack trace from Jakub?

Got it now. You are right. Thank you for politely helping me to get out
of my confusion.

  parent reply	other threads:[~2017-12-22 10:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21  7:26 [Patch net] net_sched: fix a missing rcu barrier in mini_qdisc_pair_swap() Cong Wang
2017-12-21  9:03 ` Jiri Pirko
2017-12-21 19:01   ` Cong Wang
2017-12-21 20:54     ` Cong Wang
2017-12-22  9:38       ` Jiri Pirko
2017-12-22 10:23     ` Jiri Pirko [this message]
2017-12-22 10:24 ` Jiri Pirko
2017-12-26 17:30 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171222102352.GD11519@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=jiri@mellanox.com \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).