From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [Patch net] net_sched: fix a missing rcu barrier in mini_qdisc_pair_swap() Date: Fri, 22 Dec 2017 11:23:52 +0100 Message-ID: <20171222102352.GD11519@nanopsycho> References: <20171221072624.6204-1-xiyou.wangcong@gmail.com> <20171221090313.GB1930@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Kernel Network Developers , Jiri Pirko , John Fastabend To: Cong Wang Return-path: Received: from mail-wr0-f172.google.com ([209.85.128.172]:37047 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756989AbdLVKXz (ORCPT ); Fri, 22 Dec 2017 05:23:55 -0500 Received: by mail-wr0-f172.google.com with SMTP id f8so16725225wre.4 for ; Fri, 22 Dec 2017 02:23:54 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Thu, Dec 21, 2017 at 08:01:35PM CET, xiyou.wangcong@gmail.com wrote: >On Thu, Dec 21, 2017 at 1:03 AM, Jiri Pirko wrote: >> Thu, Dec 21, 2017 at 08:26:24AM CET, xiyou.wangcong@gmail.com wrote: [...] > > >Seriously? It is this call_rcu still flying after we free the qdisc. >Did you seriously look into the stack trace from Jakub? Got it now. You are right. Thank you for politely helping me to get out of my confusion.