From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Gianluca Borello <g.borello@gmail.com>
Cc: netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net
Subject: Re: [PATCH bpf-next] bpf: fix stacksafe exploration when comparing states
Date: Sat, 23 Dec 2017 11:08:14 -0800 [thread overview]
Message-ID: <20171223190812.bh4gvbijrhrsqf4q@ast-mbp> (raw)
In-Reply-To: <20171223100955.7208-1-g.borello@gmail.com>
On Sat, Dec 23, 2017 at 10:09:55AM +0000, Gianluca Borello wrote:
...
> Fixes: cc2b14d51053 ("bpf: teach verifier to recognize zero initialized stack")
> Signed-off-by: Gianluca Borello <g.borello@gmail.com>
> Acked-by: Alexei Starovoitov <ast@kernel.org>
> ---
> kernel/bpf/verifier.c | 2 +-
> tools/testing/selftests/bpf/test_verifier.c | 51 +++++++++++++++++++++++++++++
> 2 files changed, 52 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 8b442ae125d0..93e1c77dae1d 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -4107,7 +4107,7 @@ static bool stacksafe(struct bpf_func_state *old,
>
> if (!(old->stack[spi].spilled_ptr.live & REG_LIVE_READ))
> /* explored state didn't use this */
> - return true;
> + continue;
argh. Not sure what I was thinking.
Applied, Thanks a lot Gianluca!
prev parent reply other threads:[~2017-12-23 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-23 10:09 [PATCH bpf-next] bpf: fix stacksafe exploration when comparing states Gianluca Borello
2017-12-23 19:08 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171223190812.bh4gvbijrhrsqf4q@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=g.borello@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).