From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v4 00/10] net: sched: allow qdiscs to share filter block instances Date: Sun, 24 Dec 2017 08:19:56 +0100 Message-ID: <20171224071956.GA1883@nanopsycho> References: <20171223155436.9014-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net To: David Ahern Return-path: Received: from mail-wr0-f196.google.com ([209.85.128.196]:37744 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbdLXHT7 (ORCPT ); Sun, 24 Dec 2017 02:19:59 -0500 Received: by mail-wr0-f196.google.com with SMTP id f8so20330254wre.4 for ; Sat, 23 Dec 2017 23:19:58 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Sun, Dec 24, 2017 at 02:54:47AM CET, dsahern@gmail.com wrote: >On 12/23/17 9:54 AM, Jiri Pirko wrote: >> So back to the example. First, we create 2 qdiscs. Both will share >> block number 22. "22" is just an identification. If we don't pass any >> block number, a new one will be generated by kernel: >> >> $ tc qdisc add dev ens7 ingress block 22 >> ^^^^^^^^ >> $ tc qdisc add dev ens8 ingress block 22 >> ^^^^^^^^ >> >> Now if we list the qdiscs, we will see the block index in the output: >> >> $ tc qdisc >> qdisc ingress ffff: dev ens7 parent ffff:fff1 block 22 >> qdisc ingress ffff: dev ens8 parent ffff:fff1 block 22 >> >> To make is more visual, the situation looks like this: >> >> ens7 ingress qdisc ens7 ingress qdisc >> | | >> | | >> +----------> block 22 <----------+ >> >> Unlimited number of qdiscs may share the same block. >> >> Now we can add filter to any of qdiscs sharing the same block: >> >> $ tc filter add dev ens7 ingress protocol ip pref 25 flower dst_ip 192.168.0.0/16 action drop > > >Allowing config of a shared block through any qdisc that references it >is akin to me allowing nexthop objects to be manipulated by any route >that references it -- sure, it could be done but causes a lot surprises >to the user. > >You are adding a new tc object -- a shared block. Why the resistance to >creating a proper API for managing it? Again, no resistance, I said many times it would be done as a follow-up. But as an api already exists, it has to continue to work. Or do you suggest it should stop working? That, I don't agree with.