From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next] virtio_net: Add ethtool stats Date: Sun, 24 Dec 2017 10:16:40 -0800 Message-ID: <20171224101640.4b14002f@xeon-e3> References: <1513744837-2672-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , "Michael S . Tsirkin" , Jason Wang , netdev@vger.kernel.org, virtualization@lists.linux-foundation.org To: Toshiaki Makita Return-path: Received: from mail-pl0-f43.google.com ([209.85.160.43]:46335 "EHLO mail-pl0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbdLXSQo (ORCPT ); Sun, 24 Dec 2017 13:16:44 -0500 Received: by mail-pl0-f43.google.com with SMTP id i6so15718158plt.13 for ; Sun, 24 Dec 2017 10:16:44 -0800 (PST) In-Reply-To: <1513744837-2672-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 20 Dec 2017 13:40:37 +0900 Toshiaki Makita wrote: > + > +static const struct virtnet_gstats virtnet_gstrings_stats[] = { > + { "rx_packets", VIRTNET_NETDEV_STAT(rx_packets) }, > + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, > + { "rx_bytes", VIRTNET_NETDEV_STAT(rx_bytes) }, > + { "tx_bytes", VIRTNET_NETDEV_STAT(tx_bytes) }, > + { "rx_dropped", VIRTNET_NETDEV_STAT(rx_dropped) }, > + { "rx_length_errors", VIRTNET_NETDEV_STAT(rx_length_errors) }, > + { "rx_frame_errors", VIRTNET_NETDEV_STAT(rx_frame_errors) }, > + { "tx_dropped", VIRTNET_NETDEV_STAT(tx_dropped) }, > + { "tx_fifo_errors", VIRTNET_NETDEV_STAT(tx_fifo_errors) }, > +}; > + Please do not merge pre-existing global stats into ethtool. It just duplicates existing functionality.