From: Stephen Hemminger <stephen@networkplumber.org>
To: Serhey Popovych <serhe.popovych@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 1/3] vxcan,veth: Forbid "type" for peer device
Date: Tue, 26 Dec 2017 09:05:35 -0800 [thread overview]
Message-ID: <20171226090535.51ac43ef@xeon-e3> (raw)
In-Reply-To: <1513755451-9800-2-git-send-email-serhe.popovych@gmail.com>
On Wed, 20 Dec 2017 09:37:29 +0200
Serhey Popovych <serhe.popovych@gmail.com> wrote:
> It is already given for original device we configure this
> peer for.
>
> Results from following command before/after change applied
> are shown below:
>
> $ ip link add dev veth1a type veth peer name veth1b \
> type veth peer name veth1c
>
> Before:
> -------
>
> <no output, no netdevs created>
>
> After:
> ------
>
> Error: argument "type" is wrong: not supported for peer
>
> Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
This makes a lot of sense.
Maybe the better error message would be to use duparg() since
that is the most likely cause of the user error.
next prev parent reply other threads:[~2017-12-26 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 7:37 [PATCH iproute2 0/3] Forbid "type" for peer, update ifname and make it array in ll_cache Serhey Popovych
2017-12-20 7:37 ` [PATCH iproute2 1/3] vxcan,veth: Forbid "type" for peer device Serhey Popovych
2017-12-26 17:05 ` Stephen Hemminger [this message]
2017-12-28 10:54 ` Serhey Popovych
2017-12-28 11:01 ` Serhey Popovych
2017-12-28 17:40 ` Stephen Hemminger
2017-12-20 7:37 ` [PATCH iproute2 2/3] utils: ll_map: Update name and type for existing entry Serhey Popovych
2017-12-28 17:46 ` Stephen Hemminger
2017-12-28 18:22 ` Serhey Popovych
2017-12-20 7:37 ` [PATCH iproute2 3/3] utils: ll_map: Make network device name fixed size array of char Serhey Popovych
2017-12-28 17:45 ` Stephen Hemminger
2017-12-28 18:17 ` Serhey Popovych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171226090535.51ac43ef@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=serhe.popovych@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).