From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 1/3] vxcan,veth: Forbid "type" for peer device Date: Tue, 26 Dec 2017 09:05:35 -0800 Message-ID: <20171226090535.51ac43ef@xeon-e3> References: <1513755451-9800-1-git-send-email-serhe.popovych@gmail.com> <1513755451-9800-2-git-send-email-serhe.popovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Serhey Popovych Return-path: Received: from mail-pf0-f173.google.com ([209.85.192.173]:36512 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbdLZRFj (ORCPT ); Tue, 26 Dec 2017 12:05:39 -0500 Received: by mail-pf0-f173.google.com with SMTP id p84so18898506pfd.3 for ; Tue, 26 Dec 2017 09:05:39 -0800 (PST) In-Reply-To: <1513755451-9800-2-git-send-email-serhe.popovych@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 20 Dec 2017 09:37:29 +0200 Serhey Popovych wrote: > It is already given for original device we configure this > peer for. > > Results from following command before/after change applied > are shown below: > > $ ip link add dev veth1a type veth peer name veth1b \ > type veth peer name veth1c > > Before: > ------- > > > > After: > ------ > > Error: argument "type" is wrong: not supported for peer > > Signed-off-by: Serhey Popovych This makes a lot of sense. Maybe the better error message would be to use duparg() since that is the most likely cause of the user error.