From: Stephen Hemminger <stephen@networkplumber.org>
To: Serhey Popovych <serhe.popovych@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 0/2] ip/tunnel: Do not free() answer on rtnl_talk() error, correct ip6gre
Date: Tue, 26 Dec 2017 09:08:45 -0800 [thread overview]
Message-ID: <20171226090845.0d69d42f@xeon-e3> (raw)
In-Reply-To: <1513756630-14639-1-git-send-email-serhe.popovych@gmail.com>
On Wed, 20 Dec 2017 09:57:08 +0200
Serhey Popovych <serhe.popovych@gmail.com> wrote:
> In this series I present next set of improvements/fixes:
>
> 1) If rtnl_talk(), called with answer != NULL fails it
> never returns with allocated answer: no need to
> initialize answer and free() it in the caller on error.
>
> 2) Correct ip6gre print endpoint address printing with
> ll_addr_n2a(): endpoints are IPv6 addresses, not hex
> dump.
>
> See individual patch description message for details.
>
> Thanks,
> Serhii
>
> Serhey Popovych (2):
> utils: ll_addr: Handle ARPHRD_IP6GRE in ll_addr_n2a()
> ip/tunnel: No need to free answer after rtnl_talk() on error
>
> ip/link_gre.c | 3 +--
> ip/link_gre6.c | 3 +--
> ip/link_ip6tnl.c | 3 +--
> ip/link_iptnl.c | 3 +--
> ip/link_vti.c | 3 +--
> ip/link_vti6.c | 3 +--
> lib/ll_addr.c | 3 ++-
> 7 files changed, 8 insertions(+), 13 deletions(-)
>
Applied, thanks.
prev parent reply other threads:[~2017-12-26 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 7:57 [PATCH iproute2 0/2] ip/tunnel: Do not free() answer on rtnl_talk() error, correct ip6gre Serhey Popovych
2017-12-20 7:57 ` [PATCH iproute2 1/2] utils: ll_addr: Handle ARPHRD_IP6GRE in ll_addr_n2a() Serhey Popovych
2017-12-20 7:57 ` [PATCH iproute2 2/2] ip/tunnel: No need to free answer after rtnl_talk() on error Serhey Popovych
2017-12-26 17:08 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171226090845.0d69d42f@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=serhe.popovych@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).