From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 0/2] ip/tunnel: Do not free() answer on rtnl_talk() error, correct ip6gre Date: Tue, 26 Dec 2017 09:08:45 -0800 Message-ID: <20171226090845.0d69d42f@xeon-e3> References: <1513756630-14639-1-git-send-email-serhe.popovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Serhey Popovych Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:37008 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbdLZRIs (ORCPT ); Tue, 26 Dec 2017 12:08:48 -0500 Received: by mail-pf0-f196.google.com with SMTP id n6so18894293pfa.4 for ; Tue, 26 Dec 2017 09:08:48 -0800 (PST) In-Reply-To: <1513756630-14639-1-git-send-email-serhe.popovych@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 20 Dec 2017 09:57:08 +0200 Serhey Popovych wrote: > In this series I present next set of improvements/fixes: > > 1) If rtnl_talk(), called with answer != NULL fails it > never returns with allocated answer: no need to > initialize answer and free() it in the caller on error. > > 2) Correct ip6gre print endpoint address printing with > ll_addr_n2a(): endpoints are IPv6 addresses, not hex > dump. > > See individual patch description message for details. > > Thanks, > Serhii > > Serhey Popovych (2): > utils: ll_addr: Handle ARPHRD_IP6GRE in ll_addr_n2a() > ip/tunnel: No need to free answer after rtnl_talk() on error > > ip/link_gre.c | 3 +-- > ip/link_gre6.c | 3 +-- > ip/link_ip6tnl.c | 3 +-- > ip/link_iptnl.c | 3 +-- > ip/link_vti.c | 3 +-- > ip/link_vti6.c | 3 +-- > lib/ll_addr.c | 3 ++- > 7 files changed, 8 insertions(+), 13 deletions(-) > Applied, thanks.