From: Ido Schimmel <idosch@idosch.org>
To: Willy Tarreau <w@1wt.eu>
Cc: Wei Wang <weiwan@google.com>, Martin KaFai Lau <kafai@fb.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Sasha Levin <alexander.levin@verizon.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chris Rankin <rankincj@gmail.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: BUG warnings in 4.14.9
Date: Tue, 26 Dec 2017 22:54:37 +0200 [thread overview]
Message-ID: <20171226205436.GA32546@splinter> (raw)
In-Reply-To: <20171226185955.GA19208@1wt.eu>
On Tue, Dec 26, 2017 at 07:59:55PM +0100, Willy Tarreau wrote:
> Guys,
>
> Chris reported the bug below and confirmed that reverting commit
> 9704f81 (ipv6: grab rt->rt6i_ref before allocating pcpu rt) seems to
> have fixed the issue for him. This patch is a94b9367 in mainline.
>
> I personally have no opinion on the patch, just found it because it
> was the only one touching this area between 4.14.8 and 4.14.9 :-)
>
> Should this be reverted or maybe fixed differently ?
Maybe I'm missing something, but how come this patch even made its way
into 4.14.y? It's part of a series to RCU-ify IPv6 FIB lookup that went
into 4.15.
Anyway, the mentioned bug was already fixed by commit 951f788a80ff
("ipv6: fix a BUG in rt6_get_pcpu_route()") when the code was still in
net-next.
next prev parent reply other threads:[~2017-12-26 20:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAK2bqV+NqMz0e-uVGREMvmmi_NgKRYyqZ8kd+yEfxT0pcCWE+g@mail.gmail.com>
2017-12-26 18:59 ` BUG warnings in 4.14.9 Willy Tarreau
2017-12-26 20:54 ` Ido Schimmel [this message]
2017-12-27 4:25 ` alexander.levin
2017-12-27 12:57 ` Greg Kroah-Hartman
2017-12-26 23:08 ` alexander.levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171226205436.GA32546@splinter \
--to=idosch@idosch.org \
--cc=alexander.levin@verizon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rankincj@gmail.com \
--cc=stable@vger.kernel.org \
--cc=w@1wt.eu \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).