From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v2 00/10] Add support for resource abstraction Date: Wed, 27 Dec 2017 14:15:31 +0100 Message-ID: <20171227131531.GE1997@nanopsycho> References: <20171226112359.5313-1-jiri@resnulli.us> <20171227080902.GA1997@nanopsycho> <20171227082331.GA10517@lunn.ch> <20171227093754.GB1997@nanopsycho> <20171227130803.GA31962@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Ahern , netdev@vger.kernel.org, davem@davemloft.net, arkadis@mellanox.com, mlxsw@mellanox.com, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, linville@tuxdriver.com, gospo@broadcom.com, steven.lin1@broadcom.com, yuvalm@mellanox.com, ogerlitz@mellanox.com, roopa@cumulusnetworks.com To: Andrew Lunn Return-path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:38150 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbdL0NPd (ORCPT ); Wed, 27 Dec 2017 08:15:33 -0500 Received: by mail-wr0-f195.google.com with SMTP id o2so36718831wro.5 for ; Wed, 27 Dec 2017 05:15:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171227130803.GA31962@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Dec 27, 2017 at 02:08:03PM CET, andrew@lunn.ch wrote: >> This is misunderstanding I believe. This is not about ABI. That is well >> defined by the netlink attributes. This is about meaning of particular >> ASIC-specific internal resources. > >I would agree that the netlink attributed are clearly defined. But the >meta information, what this ASIC specific internal resource means when >you combine these attributes, is unclear. This meta information is >also part of the ABI, and documenting giving users a hit what it >means, and why they should change it, would be good practice. > >Look at sysfs. open/read/write are clearly defined, which is the >equivalent of the netlink attributes. The meta information we document >in Documentation/ABI/, what a file name means, what a value means, >what other values it can take, etc. Hmm. That documents mainly sysfs. No mention of Netlink at all. But maybe I missed it. Also, that defines the interface as is. However we are talking about the data exchanged over the interface, not the interface itself. I don't see how ASIC/HW specific thing, like for example KVD in our case could be part of kernel ABI. That makes 0 sense to me, sorry.