From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 0/3] ip/tunnel: Fix noencap- and document "external" parameter handling. Date: Wed, 27 Dec 2017 13:47:12 -0800 Message-ID: <20171227134712.12338c7c@xeon-e3> References: <1514374096-1473-1-git-send-email-serhe.popovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Serhey Popovych Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:44094 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751871AbdL0VrP (ORCPT ); Wed, 27 Dec 2017 16:47:15 -0500 Received: by mail-pl0-f66.google.com with SMTP id n13so20070501plp.11 for ; Wed, 27 Dec 2017 13:47:15 -0800 (PST) In-Reply-To: <1514374096-1473-1-git-send-email-serhe.popovych@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 27 Dec 2017 13:28:13 +0200 Serhey Popovych wrote: > In this series I present next set of improvements/fixes: > > 1) Fix noencap- option handling: we need to clear bit, instead > of seting all, but one we expect to clear. > > 2) Document "external" parameter both in ip-link(8) and help > output for link_gre.c. Add "noexternal" option variant to > bring inline with GENEVE and VXLAN. > > 3) Trivial: clear flowlabel/tclass from flowinfo in case of > inherit to stop sending garbage to the kernel. It has no > functional change, but follows similar behaviour in link_ip6tnl.c > > See individual patch description message for details. > > Thanks, > Serhii > > Serhey Popovych (3): > gre,ip6tnl/tunnel: Fix noencap- support > gre6/tunnel: Do not submit garbage in flowinfo > ip/tunnel: Document "external" parameter > > ip/link_gre.c | 7 +++++-- > ip/link_gre6.c | 4 ++-- > ip/link_ip6tnl.c | 6 ++++-- > ip/link_iptnl.c | 4 +++- > man/man8/ip-link.8.in | 6 ++++++ > 5 files changed, 20 insertions(+), 7 deletions(-) > These are really disjoint. I applied the noencap and the flowinfo patch. Agree with William that having noexternal which does nothing useful is of little value now.