From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [patch net-next v5 05/10] net: sched: keep track of offloaded filters and check tc offload feature Date: Wed, 27 Dec 2017 20:12:35 -0800 Message-ID: <20171227201235.08557349@cakuba.netronome.com> References: <20171226141604.1605-1-jiri@resnulli.us> <20171226141604.1605-6-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net, dsahern@gmail.com To: Jiri Pirko Return-path: Received: from mx3.wp.pl ([212.77.101.9]:42206 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753046AbdL1EMp (ORCPT ); Wed, 27 Dec 2017 23:12:45 -0500 In-Reply-To: <20171226141604.1605-6-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 26 Dec 2017 15:15:59 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > During block bind, we need to check tc offload feature. If it is > disabled yet still the block contains offloaded filters, forbid the > bind. Also forbid to register callback for a block that already > containes offloaded filters, as the play back is not supported now. > For keeping track of offloaded filters there is a new counter > introduced, alongside with couple of helpers called from cls_* code. > These helpers set and clear TCA_CLS_FLAGS_IN_HW flag. > > Signed-off-by: Jiri Pirko LGTM, thanks!