From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH v3 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.9 Date: Wed, 27 Dec 2017 20:19:06 -0800 Message-ID: <20171227201906.08e244bb@cakuba.netronome.com> References: <20171227191629.4920-1-guro@fb.com> <20171227191629.4920-2-guro@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: , , , Alexei Starovoitov , Daniel Borkmann To: Roman Gushchin Return-path: In-Reply-To: <20171227191629.4920-2-guro@fb.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 27 Dec 2017 19:16:29 +0000, Roman Gushchin wrote: > Bpftool build is broken with binutils version 2.29 and later. > The cause is commit 003ca0fd2286 ("Refactor disassembler selection") > in the binutils repo, which changed the disassembler() function > signature. > > Fix this by adding a new "feature" to the tools/build/features > infrastructure and make it responsible for decision which > disassembler() function signature to use. > > Signed-off-by: Roman Gushchin > Cc: Jakub Kicinski > Cc: Alexei Starovoitov > Cc: Daniel Borkmann Acked-by: Jakub Kicinski